hector-bot/argus
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: use DELETE (done) instead of PATCH (read) for GitHub notifications

Browse source 
PATCH only marks as read — notification stays in inbox.
DELETE marks as done — removes from inbox entirely.
This commit is contained in:
Nazim 2026-03-26 16:23:32 +00:00
parent 34dfdaaa70
commit 31ca165499
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bin/argus
View file

@ -652,16 +652,16 @@ def cmd_notif_pull(args) -> None:
else:
kept_count += 1
# Mark as read on GitHub (prevents re-fetching ~5000 stale notifications)
# Mark as done on GitHub (DELETE removes from inbox entirely)
if not args.dry_run and backend == "gh":
try:
subprocess.run(
["gh", "api", "--method", "PATCH",
["gh", "api", "--method", "DELETE",
f"notifications/threads/{notif_id}"],
capture_output=True, text=True, check=False
)
except Exception:
pass # Best-effort — don't fail the pull if marking read fails
pass # Best-effort — don't fail the pull if marking done fails
if not args.dry_run:
# Record poll